On Mon, Jun 30, 2025 at 06:00:12PM +0530, Krishna Chaitanya Chundru wrote: > > > On 6/23/2025 4:37 PM, Manivannan Sadhasivam wrote: > > On Thu, Jun 05, 2025 at 02:00:36PM +0530, Krishna Chaitanya Chundru wrote: > > > The main intention of this series is to move wake# to the root port node. > > > After this series we will come up with a patch which registers for wake IRQ > > > from the pcieport driver. The wake IRQ is needed for the endpoint to wakeup > > > the host from D3cold. The driver change for wake IRQ is posted here[1]. > > > > > > There are many places we agreed to move the wake and perst gpio's > > > and phy etc to the pcie root port node instead of bridge node[2] as the > > > these properties are root port specific and does not belongs to > > > bridge node. > > > > > > So move the phy, phy-names, wake-gpio's in the root port. > > > There is already reset-gpio defined for PERST# in pci-bus-common.yaml, > > > start using that property instead of perst-gpio. > > > > > > For backward compatibility, don't remove any existing properties in the > > > bridge node. > > > > > > There are some other properties like num-lanes, max-link-speed which > > > needs to be moved to the root port nodes, but in this series we are > > > excluding them for now as this requires more changes in dwc layer and > > > can complicate the things. > > > > > > Once this series gets merged all other platforms also will be updated > > > to use this new way. > > > > > > Note:- The driver change needs to be merged first before dts changes. > > > Krzysztof Wilczyński or Mani can you provide the immutable branch with > > > these PCIe changes. > > > > > > > You've dropped the DTS changes in this revision. So the above comment is stale. > > > > > [1] https://lore.kernel.org/all/20250401-wake_irq_support-v1-0-d2e22f4a0efd@xxxxxxxxxxxxxxxx/ > > > [2] https://lore.kernel.org/linux-pci/20241211192014.GA3302752@bhelgaas/ > > > > > > > I don't have a device to test this series right now. So could you please test > > this series with the legacy binding and make sure it is not breaking? > > > > Once you confirm, I'll merge this series. > > > I have verified with legacy binding with this change and it is working fine. > Thanks! Could you please rebase this series on top of pci/controller/qcom and resend? - Mani -- மணிவண்ணன் சதாசிவம்
