On Thu, 26 Jun 2025 16:42:09 -0700 Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote: > On 6/26/25 3:42 PM, Terry Bowman wrote: > > The CXL AER error handling logic currently resides in the AER driver file, > > drivers/pci/pcie/aer.c. CXL specific changes are conditionally compiled > > using #ifdefs. > > > > Improve the AER driver maintainability by separating the CXL specific logic > > from the AER driver's core functionality and removing the #ifdefs. > > Introduce drivers/pci/pcie/cxl_aer.c and move the CXL AER logic into the > > new file. > > > > Update the makefile to conditionally compile the CXL file using the > > existing CONFIG_PCIEAER_CXL Kconfig. > > > > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > > --- > > After moving the code , you seem to have updated it with your own > changes. May be you split it into two patches. Agreed. I think the changes are small but a direct code move followed by cleanup (I think it's the mask and the comment update only?) would be better. Assuming you do that, for both resulting patches: Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
