On Thu, 26 Jun 2025, Matthew W Carlis wrote:
> I have reached out several times about issues caused by the
> pcie_failed_link_retrain() quirk. Initially there were some additional changes
> that we made to try and reduce the occurrences, but I have continued to
> observe issues where hot-plug slots end up at Gen1 speed when they should not
> have been or the quirk invoked when the link is not actually training at all.
Have you verified that with a fix[1] applied for a regression introduced
by commit de9a6c8d5dbf ("PCI/bwctrl: Add pcie_set_target_speed() to set
PCIe Link Speed") discussed in the other thread[2] you can still see those
issues?
References:
[1] "PCI: Fix the issue of failed speed limit lifting",
<https://lore.kernel.org/r/20250123055155.22648-1-sjiwei@xxxxxxx/>
[2] "PCI: Fix link speed calculation on retrain failure",
<https://lore.kernel.org/r/1c92ef6bcb314ee6977839b46b393282e4f52e74.1750684771.git.lukas@xxxxxxxxx/>
Maciej
