> > > > + resets = <&syscon ASPEED_RESET_H2X>, > > > > + <&syscon ASPEED_RESET_PCIE_RC_O>; > > > > + reset-names = "h2x", "perst"; > > > > > > PERST# is clearly a per-Root Port item since it's a signal on the > > > PCIe connector. Can you separate this and any other per-Root Port > > > things into a Root Port stanza to leave open the possibility of > > > future hardware that supports multiple Root Ports in the RC? > > > > The PCIe RC that designed by us is only one root port. > > Yes. But this driver may be used in the future for other RCs that include more > than one Root Port, and it would be good if that didn't require structural > changes to the DT. Also, there are RCs from other vendors that include more > than one Root Port, and I'd like all the DTs and drivers to have similar > structure. Thanks. Is the "pciec" node in arch/arm/boot/dts/marvell/armada-385.dtsi what you said? Or could you provide some examples for us to modify our pcie rc node? Thanks, Jacky
