On Mon, Jun 23 2025 at 11:26, Lorenzo Pieralisi wrote: > On Fri, Jun 20, 2025 at 09:18:32PM +0200, Thomas Gleixner wrote: >> Just add a MSI flag and set it in parent_ops::required_flags and extend > > I added that but it does not work (not if we use d->flags as below), it works > if I add it as an > > IRQ_DOMAIN_FLAG_* > > and set it in irq_domain_info in the msi_create_parent_irq_domain() > call in the GICv5 ITS driver when creating the domain. > >> the lib with >> >> struct fwnode_handle *fwh; >> >> fwh = d->flags & MAGIC ? fwnode_get_parent(fwspec->fwnode) : fwspec->fwnode; > > Here we are using the domain flags and I think that's what we want. > > If I go with parent_ops flag, I believe here we need to use the parent > msi_domain_info::flags - I don't think that's what we want. > > It is a property of the IRQ domain so I think that adding an > > IRQ_DOMAIN_FLAG_FWNODE_PARENT > > is the best option. > > Please let me know. Obviously. Doh :)
