----- Original Message ----- > From: "Christoph Hellwig" <hch@xxxxxxxxxxxxx> > To: "Timothy Pearson" <tpearson@xxxxxxxxxxxxxxxxxxxxx> > Cc: "linuxppc-dev" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-pci" > <linux-pci@xxxxxxxxxxxxxxx>, "Madhavan Srinivasan" <maddy@xxxxxxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, > "christophe leroy" <christophe.leroy@xxxxxxxxxx>, "Naveen N Rao" <naveen@xxxxxxxxxx>, "Bjorn Helgaas" > <bhelgaas@xxxxxxxxxx>, "Shawn Anastasio" <sanastasio@xxxxxxxxxxxxxxxxxxxxx> > Sent: Wednesday, June 18, 2025 12:38:56 AM > Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops > On Tue, Jun 17, 2025 at 11:22:39PM -0500, Timothy Pearson wrote: >> /* Platform dependent EEH operations */ >> struct eeh_ops *eeh_ops = NULL; >> +EXPORT_SYMBOL(eeh_ops); > > Exporting ops vectors is generally a really bad idea. Please build a > proper abstraction instead. > > And use EXPORT_SYMBOL_GPL for any kind of low-level API. Fair enough. I'll add a properly exported method for PE get_state() and update the series in the next couple of days.
