----- Original Message ----- > From: "Bjorn Helgaas" <helgaas@xxxxxxxxxx> > To: "Timothy Pearson" <tpearson@xxxxxxxxxxxxxxxxxxxxx> > Cc: "linux-pci" <linux-pci@xxxxxxxxxxxxxxx>, "mahesh" <mahesh@xxxxxxxxxxxxx>, "Oliver" <oohall@xxxxxxxxx>, "Madhavan > Srinivasan" <maddy@xxxxxxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Lukas Wunner" <lukas@xxxxxxxxx> > Sent: Tuesday, June 17, 2025 11:04:28 AM > Subject: Re: [PATCH v10] PCI: Add pcie_link_is_active() function > On Tue, Jun 17, 2025 at 10:41:58AM -0500, Timothy Pearson wrote: >> Add pcie_link_is_active() function to check if the physical PCIe link is >> active, replacing duplicate code in multiple locations. >> >> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx> >> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx> > > Whoa, whoa, slow down. This doesn't address all the things I > mentioned (EXPORT_SYMBOL, for example). But four postings in 90 > minutes is way too much. There's no hurry, everybody has other things > to do, and we can only assimilate a reposting every few days. That > way others have a chance to respond with additional feedback, and you > can address it all at once. Understood, my apologies. I realized I had sent a couple of incorrect versions in, and wanted to avoid the known commentary on what was done wrong. > When you do post an updated version, consider adding a brief changelog > (e.g., what changed between v8 and v9) below the "---" line so we know > what to look for. > > > +EXPORT_SYMBOL(pcie_link_is_active); Will do in the future. There is some urgency on this overall patchset as we have had hotplug support broken for many years now, and it's causing continued problems on customer deployed machines. While we can continue to point customers at the patchset and have them compile their own kernels, patience from our customer side is wearing a bit thin for that. I will continue to try to push this forward (along with the associated ppc patch set) at a more reasonable pace. Thanks!
