Hi Nicolas, On 6/12/25 9:56 PM, Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Remove VOP2's HIWORD_UPDATE macro from the vop2 header file, and replace > all instances in rockchip_vop2_reg.c (the only user of this particular > HIWORD_UPDATE definition) with equivalent HWORD_UPDATE instances. This > gives us better error checking. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> This LGTM and I also confirm it works as expected on my Radxa boards: ROCK 3A (RK3568) and ROCK 5B (RK3588). Hence, Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> Tested-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
