On Thu, Jun 12, 2025 at 08:56:17PM +0200, Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Like many other Rockchip drivers, dwmac-rk has its own HIWORD_UPDATE > macro. Its semantics allow us to redefine it as a wrapper to the shared > bitfield.h HWORD_UPDATE macros though. > > Replace the implementation of this driver's very own HIWORD_UPDATE macro > with an instance of HWORD_UPDATE from bitfield.h. This keeps the diff > easily reviewable, while giving us more compile-time error checking. > > The related GRF_BIT macro is left alone for now; any attempt to rework > the code to not use its own solution here would likely end up harder to > review and less pretty for the time being. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> Please split this out into a patch for net-next. Also, Russell King has just posted a number of patches for this driver, so you will probably want to wait for them to be merged, so you post something which will merged without any fuzz. Andrew
