On Mon, Mar 10, 2025 at 09:51:03AM +0000, Wannes Bouwen (Nokia) wrote: > Subject: [v2 PATCH 1/1] PCI: of: avoid warning for 4 GiB non-prefetchable windows. > There should be no 'Subject' prefix. Also, the subject is not accurate. This patch fixes the check that is supposed to check the PCI address range of the non-prefetchable region to be within 32bit boundary, but it was checking the size. > According to the PCIe spec (PCIe r6.3, sec 7.5.1.3.8), non-prefetchable memory > supports only 32-bit host bridge windows (both base address as limit address). > > In the kernel there is a check that prints a warning if a > non-prefetchable resource's size exceeds the 32-bit limit. > > The check currently checks the size of the resource, while actually the > check should be done on the PCIe end address of the non-prefetchable > window. > > Move the check to devm_of_pci_get_host_bridge_resources() where the PCIe > addresses are available and use the end address instead of the size of > the window to avoid warnings for 4 GiB windows. > 'to avoid warnings for 4 GiB windows' doesn't really matter here, though that was your intention of patch v1. I think a fixes tag pointing to commit, fede8526cc48 is also needed. > Signed-off-by: Wannes Bouwen <wannes.bouwen@xxxxxxxxx> > --- You should include the changelog for v2->v1 here. - Mani -- மணிவண்ணன் சதாசிவம்
