On Tue, Jun 10, 2025 at 12:07:00AM -0700, Nicolin Chen wrote: > On Tue, Jun 10, 2025 at 12:26:07PM +0800, Baolu Lu wrote: > > On 6/10/25 02:45, Nicolin Chen wrote: > > > + ops = dev_iommu_ops(dev); > > > > Should this be protected by group->mutext? > > Not seemingly, but should require the iommu_probe_device_lock I > think. group and ops are not permitted to change while a driver is attached.. IIRC the FLR code in PCI doesn't always ensure that (due to the sysfs paths), so yeah, this looks troubled. iommu_probe_device_lock perhaps would fix it. Jason
