Re: [PATCH 1/4] PCI: Don't show errors on inaccessible PCI devices

[Mario Limonciello <superm1@xxxxxxxxxx>]

On 6/9/2025 10:09 AM, Lukas Wunner wrote:
> [cc += Rafael, Mika]
>
> On Sun, Jun 08, 2025 at 08:58:01PM -0500, Mario Limonciello wrote:
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -1376,8 +1376,9 @@ int pci_power_up(struct pci_dev *dev)
> >   
> >   	pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> >   	if (PCI_POSSIBLE_ERROR(pmcsr)) {
> > -		pci_err(dev, "Unable to change power state from %s to D0, device inaccessible\n",
> > -			pci_power_name(dev->current_state));
> > +		if (dev->error_state != pci_channel_io_perm_failure)
> > +			pci_err(dev, "Unable to change power state from %s to D0, device inaccessible\n",
> > +				pci_power_name(dev->current_state));
> >   		dev->current_state = PCI_D3cold;
> >   		return -EIO;
> >   	}
>
> Instead of merely silencing the error message, why not bail out early on
> in the function, i.e.
>
> 	if (pci_dev_is_disconnected(dev)) {
> 		dev->current_state = PCI_D3cold;
> 		return -EIO;
> 	}

Thanks for the suggestion.  That sounds good to me, I'll have a try.