On Sun, Jun 01, 2025 at 12:25:15AM +0800, Xu Yilun wrote: > > + * struct iommu_vdevice_id - ioctl(IOMMU_VDEVICE_TSM_BIND/UNBIND) > > + * @size: sizeof(struct iommu_vdevice_id) > > + * @vdevice_id: Object handle for the vDevice. Returned from IOMMU_VDEVICE_ALLOC > > + */ > > +struct iommu_vdevice_id { > > + __u32 size; > > + __u32 vdevice_id; > > +} __packed; > > +#define IOMMU_VDEVICE_TSM_BIND _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VDEVICE_TSM_BIND) > > +#define IOMMU_VDEVICE_TSM_UNBIND _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VDEVICE_TSM_UNBIND) > > Hello, I see you are talking about the detailed implementation. But > could we firstly address the confusing whether this TSM Bind/Unbind > should be a VFIO uAPI or IOMMUFD uAPI? I thought you guys had moved past that? VFIO doesn't have enough information so iommufd would be a better place to make the call? Jason