> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 21 May 2025 15:03 > To: Shradha Todi <shradha.t@xxxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx; manivannan.sadhasivam@xxxxxxxxxx; lpieralisi@xxxxxxxxxx; > kw@xxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; jingoohan1@xxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > alim.akhtar@xxxxxxxxxxx; vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; arnd@xxxxxxxx; m.szyprowski@xxxxxxxxxxx; > jh80.chung@xxxxxxxxxxx > Subject: Re: [PATCH 07/10] dt-bindings: phy: Add PHY bindings support for FSD SoC > > On Mon, May 19, 2025 at 01:01:49AM GMT, Shradha Todi wrote: > > Document PHY device tree bindings for Tesla FSD SoCs. > > > > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml | 8 > > ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml > > index 41df8bb08ff7..3a5bff0fb82d 100644 > > --- > > a/Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.ya > > +++ ml > > @@ -15,10 +15,14 @@ properties: > > const: 0 > > > > compatible: > > - const: samsung,exynos5433-pcie-phy > > + oneOf: > > Drop, that's just enumm unless you already add here more? > > > + - enum: > > + - samsung,exynos5433-pcie-phy > > + - tesla,fsd-pcie-phy > > > > reg: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 > > You need to list the items and constrain existing variants. I do not get why exynos5433 gets now two MMIO ranges. > Will constraint both variants with if - else > Best regards, > Krzysztof
