Re: POSSIBLE REGRESSION: PCI/pwrctrl: Skip scanning for the device further if pwrctrl device is created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 05, 2025 at 01:39:39PM -0400, Jim Quinlan wrote:
> Hello,
> 
> I recently rebased to the latest Linux master
> 
> ebd297a2affa Linus.Torvalds Merge tag 'net-6.15-rc5' of
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
> 
> and noticed that PCI is broken for
> "drivers/pci/controller/pcie-brcmstb.c"  I've bisected this to the
> following commit
> 
> 2489eeb777af PCI/pwrctrl: Skip scanning for the device further if
> pwrctrl device is created
> 

Thanks a lot for the report and sorry for the delay in getting back.

> which is part of the series [1].  The driver in pcie-brcmstb.c is
> expecting the add_bus() method to be invoked twice per boot-up, but
> the second call does not happen.  Not only does this code in
> brcm_pcie_add_bus() turn on regulators, it also subsequently initiates
> PCIe linkup.
> 

May I know why add_bus() is invoked twice? The regulators are supposed to be
enabled only once. I should be missing something here.

- Mani

-- 
மணிவண்ணன் சதாசிவம்




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux