On Mon, May 19, 2025 at 01:01:51AM +0530, Shradha Todi wrote:
> Add host and endpoint controller driver support for FSD SoC.
>
> Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx>
> ---
(snip)
> +static int fsd_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
> + unsigned int type, u16 interrupt_num)
> +{
> + struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> +
> + switch (type) {
> + case PCI_IRQ_INTX:
> + case PCI_IRQ_MSIX:
> + dev_err(pci->dev, "EP does not support legacy IRQs\n");
Here you will print the same message for both INTX and MSIX.
Perhaps MSIX should have a separate print?
In fact, perhaps you want to call dw_pcie_ep_raise_intx_irq()
for case PCI_IRQ_INTX, since that function already has an error print.
Kind regards,
Niklas
