On Mon, May 12, 2025 at 11:01 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, May 9, 2025 at 5:28 PM Jim Quinlan <james.quinlan@xxxxxxxxxxxx> wrote: > > > > Add optional num-lanes property Broadcom STB PCIe host controllers. > > > > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > index 29f0e1eb5096..f31d654ac3a0 100644 > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > @@ -107,6 +107,8 @@ properties: > > - const: bridge > > - const: swinit > > > > + num-lanes: true > > Why do you need this? It is already allowed by the referenced schemas. > Though maybe you don't support 16 lanes and need to limit this to > something less? I would also set 'default' if you do that. I just thought that if our driver actually did something with "num-lanes" -- most drivers do not -- then it should be mentioned in the YAML, even if "num-lanes" is pre-defined. At any rate we cannot handle 16 lanes so I will add a "default" and "maximum". Regards, Jim Quinlan Broadcom STB > > > Rob
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
