On Mon, May 12, 2025 at 03:08:57PM +0300, Ilpo Järvinen wrote: > There are quite many reset and restore related functions in pci.c that > barely depend on the other functions in pci.c. Create reset-restore.c > for reset and restore related logic to keep those 1k lines in one place. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Hm, could I get a: Suggested-by: Lukas Wunner <lukas@xxxxxxxxx> ... per: https://lore.kernel.org/r/Z7hZZNT5NHYncZ3c@xxxxxxxxx/ > drivers/pci/Makefile | 4 +- > drivers/pci/pci.c | 1015 +---------------------------------- > drivers/pci/pci.h | 10 + > drivers/pci/reset-restore.c | 1014 ++++++++++++++++++++++++++++++++++ I'd prefer reset.c for succinctness. That said, this patch conflicts with Mani's slot reset patches which a lot of people seem to be interested in: https://lore.kernel.org/r/20250508-pcie-reset-slot-v4-0-7050093e2b50@xxxxxxxxxx/ Maybe it's better to give Mani's series the advantage and defer this patch here to the next cycle. > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -69,15 +69,7 @@ struct pci_pme_device { > */ > #define PCI_RESET_WAIT 1000 /* msec */ I'd move PCI_RESET_WAIT, pci_dev_wait() and pci_bridge_wait_for_secondary_bus() to reset.c as well. Then pci_dev_d3_sleep() is the only function which is no longer static. Thanks, Lukas
