Now that we have a concise helper to create an MSI parent domain, switch the GIC family over to that. Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> --- drivers/irqchip/irq-gic-v2m.c | 12 +++++++----- drivers/irqchip/irq-gic-v3-its.c | 19 +++++++++---------- drivers/irqchip/irq-gic-v3-mbi.c | 11 ++++++----- 3 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c index 62676994d0695..9050792e3242f 100644 --- a/drivers/irqchip/irq-gic-v2m.c +++ b/drivers/irqchip/irq-gic-v2m.c @@ -268,16 +268,18 @@ static __init int gicv2m_allocate_domains(struct irq_domain *parent) if (!v2m) return 0; - inner_domain = irq_domain_create_hierarchy(parent, 0, 0, v2m->fwnode, - &gicv2m_domain_ops, v2m); + inner_domain = msi_create_parent_irq_domain(&(struct irq_domain_info){ + .fwnode = v2m->fwnode, + .ops = &gicv2m_domain_ops, + .host_data = v2m, + .parent = parent, + }, &gicv2m_msi_parent_ops); + if (!inner_domain) { pr_err("Failed to create GICv2m domain\n"); return -ENOMEM; } - irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS); - inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT; - inner_domain->msi_parent_ops = &gicv2m_msi_parent_ops; return 0; } diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 9e6380f597488..9ea3a6723263c 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5128,20 +5128,19 @@ static int its_init_domain(struct its_node *its) info->ops = &its_msi_domain_ops; info->data = its; - inner_domain = irq_domain_create_hierarchy(its_parent, - its->msi_domain_flags, 0, - its->fwnode_handle, &its_domain_ops, - info); + inner_domain = msi_create_parent_irq_domain(&(struct irq_domain_info){ + .fwnode = its->fwnode_handle, + .ops = &its_domain_ops, + .host_data = info, + .domain_flags = its->msi_domain_flags, + .parent = its_parent, + }, &gic_v3_its_msi_parent_ops); + if (!inner_domain) { kfree(info); return -ENOMEM; } - irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS); - - inner_domain->msi_parent_ops = &gic_v3_its_msi_parent_ops; - inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT | IRQ_DOMAIN_FLAG_MSI_IMMUTABLE; - return 0; } @@ -5518,7 +5517,7 @@ static struct its_node __init *its_node_init(struct resource *res, its->base = its_base; its->phys_base = res->start; its->get_msi_base = its_irq_get_msi_base; - its->msi_domain_flags = IRQ_DOMAIN_FLAG_ISOLATED_MSI; + its->msi_domain_flags = IRQ_DOMAIN_FLAG_ISOLATED_MSI | IRQ_DOMAIN_FLAG_MSI_IMMUTABLE; its->numa_node = numa_node; its->fwnode_handle = handle; diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c index e562b57923229..11fa5df9da8c7 100644 --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -208,14 +208,15 @@ static int mbi_allocate_domain(struct irq_domain *parent) { struct irq_domain *nexus_domain; - nexus_domain = irq_domain_create_hierarchy(parent, 0, 0, parent->fwnode, - &mbi_domain_ops, NULL); + nexus_domain = msi_create_parent_irq_domain(&(struct irq_domain_info){ + .fwnode = parent->fwnode, + .ops = &mbi_domain_ops, + .parent = parent, + }, &gic_v3_mbi_msi_parent_ops); + if (!nexus_domain) return -ENOMEM; - irq_domain_update_bus_token(nexus_domain, DOMAIN_BUS_NEXUS); - nexus_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT; - nexus_domain->msi_parent_ops = &gic_v3_mbi_msi_parent_ops; return 0; } -- 2.39.2