Hello, > > > Changes for RESEND: > > > - add Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > Resending a patch is not a place to add new tags. > > While I realize that: > https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient > > states: > """ > "RESEND" only applies to resubmission of a patch or patch series which > have not been modified in any way from the previous submission. > """ Yes, I would often take verbiage of this document verbatim, but.. > I would assume that this only refers to the commit log and code, > and that picking up tags has to be an acceptable exception. The above comment prompted me to inquire with a more senior maintainers, purely as I was curious what the opinions/preferences would be. And, as such, the replies I've got were: - No, follow the documentation - I don't care, really - It's OK, make sure to pick the tag, if it makes sense So, wide spectrum of answers. As such, I take it as, "it's up to the maintainer", for lack of less ambiguous answers. > If I take myself as an example, I would not be happy if I spent time > reviewing a large patch series, but because the maintainers somehow > missed that series, so the patch author has to RESEND it (without > picking up tags), my Reviewed-by tags get lost. While it's not about making you happy, I agree, that trying to preserve the tag might be the correct approach here. As such, I will adopt this approach, whereas with other it might vary. Thank you! Krzysztof
