On Tue, May 06, 2025 at 10:06:59AM +0200, Lukas Wunner wrote: > On Mon, May 05, 2025 at 06:09:58PM -0400, Sasha Levin wrote: > > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > [ Upstream commit 2d923930f2e3fe1ecf060169f57980da819a191f ] > > > > The PCI core will try to access the devices even after pci_stop_dev() > > for things like Data Object Exchange (DOE), ASPM, etc. > > > > So, move pci_pwrctrl_unregister() to the near end of pci_destroy_dev() > > to make sure that the devices are powered down only after the PCI core > > is done with them. > > The above was patch [2/5] in this series: > > https://lore.kernel.org/r/20250116-pci-pwrctrl-slot-v3-0-827473c8fbf4@xxxxxxxxxx/ > > ... so I think the preceding patch [1/5] is a prerequisite and would > need to be cherry-picked as well. Upstream commit id is: > 957f40d039a98d630146f74f94b3f60a40a449e4 > Yes, thanks for spotting it Lukas, appreciated! > That said, I'm not sure this is really a fix that merits backporting > to stable. Mani may have more comments whether it makes sense. > Both this commit and the one corresponding to patch 1/5 are not bug fixes that warrants backporting. So please drop this one from the queue. - Mani -- மணிவண்ணன் சதாசிவம்