Hi Manivannan, Please let me know if you are expecting any further changes to this patch. Thanks, Vidya Sagar ________________________________________ From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> Sent: Friday, April 18, 2025 22:51 To: Vidya Sagar <vidyas@xxxxxxxxxx> Cc: lpieralisi@xxxxxxxxxx <lpieralisi@xxxxxxxxxx>; kw@xxxxxxxxx <kw@xxxxxxxxx>; robh@xxxxxxxxxx <robh@xxxxxxxxxx>; bhelgaas@xxxxxxxxxx <bhelgaas@xxxxxxxxxx>; cassel@xxxxxxxxxx <cassel@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx <linux-pci@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Thierry Reding <treding@xxxxxxxxxx>; Jon Hunter <jonathanh@xxxxxxxxxx>; Krishna Thota <kthota@xxxxxxxxxx>; Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>; sagar.tv@xxxxxxxxx <sagar.tv@xxxxxxxxx> Subject: Re: [PATCH V3] PCI: dwc: tegra194: Broaden architecture dependency External email: Use caution opening links or attachments On Thu, Apr 17, 2025 at 01:16:07PM +0530, Vidya Sagar wrote: > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA > check, allowing the PCIe controller to be built on Tegra platforms > beyond Tegra194. Additionally, ensure compatibility by requiring > ARM64 or COMPILE_TEST. > > Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@xxxxxxxxxx/ > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > --- > v3: > * Addressed warning from kernel test robot > > v2: > * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > drivers/phy/tegra/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index d9f0386396ed..815b6e0d6a0c 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -226,7 +226,7 @@ config PCIE_TEGRA194 > > config PCIE_TEGRA194_HOST > tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_MSI > select PCIE_DW_HOST > select PHY_TEGRA194_P2U > @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST > > config PCIE_TEGRA194_EP > tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_ENDPOINT > select PCIE_DW_EP > select PHY_TEGRA194_P2U > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > index f30cfb42b210..342fb736da4b 100644 > --- a/drivers/phy/tegra/Kconfig > +++ b/drivers/phy/tegra/Kconfig > @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB > > config PHY_TEGRA194_P2U > tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver" > - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST > + depends on ARCH_TEGRA || COMPILE_TEST > select GENERIC_PHY > help > Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்
