Re: [PATCH] nvme-pci: Fix system hang when ASPM L1 is enabled during suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2025/5/2 23:45, Manivannan Sadhasivam wrote:
On Fri, May 02, 2025 at 11:20:51AM +0800,hans.zhang@xxxxxxxxxxx  wrote:
From: Hans Zhang<hans.zhang@xxxxxxxxxxx>

When PCIe ASPM L1 is enabled (CONFIG_PCIEASPM_POWERSAVE=y), certain
NVMe controllers fail to release LPI MSI-X interrupts during system
suspend, leading to a system hang. This occurs because the driver's
existing power management path does not fully disable the device
when ASPM is active.

Why can't you add quirks for those NVMe devices instead?


Dear Mani,

static int nvme_init_identify(struct nvme_ctrl *ctrl)
  if (!ctrl->identified) {
    for (i = 0; i < ARRAY_SIZE(core_quirks); i++) {
	if (quirk_matches(id, &core_quirks[i]))
	  ctrl->quirks |= core_quirks[i].quirks;
	}


quirk_matches needs to match the vid of each NVMe SSD. At present, I have added all the vid available on the market to the quirks table, which seems very unreasonable.

Best regards,
Hans




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux