Re: [PATCH 1/1] PCI: Fix lock symmetry in pci_slot_unlock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 30, 2025 at 11:35:26AM +0300, Ilpo Järvinen wrote:
> The commit a4e772898f8b ("PCI: Add missing bridge lock to
> pci_bus_lock()") made the lock function to call depend on
> dev->subordinate but left pci_slot_unlock() unmodified creating locking
> asymmetry compared with pci_slot_lock().

Worth noting that this isn't just for symmetry:  It seems the bridge
is unlocked twice because pci_bus_unlock() unlocks bus->self and
pci_slot_unlock() then unconditionally unlocks the same bridge device
again.

Thanks,

Lukas




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux