On Wed, 23 Apr 2025, David E. Box wrote: > Replace deprecated DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE() call with the new > DEFINE_SYSFS_GROUP_VISIBILITY() helper for the pci_doe_features_sysfs group > in drivers/pci/doe.c. > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > --- > drivers/pci/doe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/doe.c b/drivers/pci/doe.c > index aae9a8a00406..18b355506dc1 100644 > --- a/drivers/pci/doe.c > +++ b/drivers/pci/doe.c > @@ -119,7 +119,7 @@ static bool pci_doe_features_sysfs_group_visible(struct kobject *kobj) > > return !xa_empty(&pdev->doe_mbs); > } > -DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(pci_doe_features_sysfs) > +DEFINE_SYSFS_GROUP_VISIBILITY(pci_doe_features_sysfs) Hi David, Is it intentional to not have semicolon at the end? > const struct attribute_group pci_doe_sysfs_group = { > .name = "doe_features", > -- i.