On Wed, Apr 23, 2025 at 10:14:57PM +0800, Hans Zhang wrote: > > I can see why you renamed PCIE_CLIENT_GENERAL_CONTROL to PCIE_CLIENT_GENERAL_CON > > (to match PCIE_CLIENT_MSG_GEN_CON). > > > > But now we have PCIE_CLIENT_MSG_GEN_CON / PCIE_CLIENT_GENERAL_CON and > > PCIE_CLIENT_HOT_RESET_CTRL. > > > > _CTRL seems like a more common shortening. How about renaming all three to > > end with _CTRL ? > > I saw that TRM is named like this. > > PCIE_CLIENT_GENERAL_CON / PCIE_CLIENT_MSG_GEN_CON / > PCIE_CLIENT_HOT_RESET_CTRL > > Shall we take TRM as the standard or your suggestion? Aha, so the inconsistency is in the TRM... hahaha :) Probably best to keep it identical to the TRM. Kind regards, Niklas