Re: [PATCH] PCI: dw-rockchip: Fix function call sequence in rockchip_pcie_phy_deinit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2025/04/17 星期四 22:21, Diederik de Haas 写道:
The documentation for the phy_power_off() function explicitly says

   Must be called before phy_exit().

So let's follow that instruction.

Thanks for this fixing.

Acked-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>


Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")
Cc: stable@xxxxxxxxxxxxxxx	# v5.15+
Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx>
---
  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index c624b7ebd118..4f92639650e3 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -410,8 +410,8 @@ static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip)
static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip)
  {
-	phy_exit(rockchip->phy);
  	phy_power_off(rockchip->phy);
+	phy_exit(rockchip->phy);
  }
static const struct dw_pcie_ops dw_pcie_ops = {




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux