On Thu, Apr 17, 2025 at 08:35:11AM +0800, Shawn Lin wrote: > There is no reason to call rockchip_pcie_ep_hide_broken_ats_cap_rk3588() > from the pre_init() callback, instead of the normal init() callback. > > Thus, move the rockchip_pcie_ep_hide_broken_ats_cap_rk3588() call from > the pre_init() callback to the init() callback, as: > 1) init() will still be called before link training is enabled, so the > quirk will still be applied before the host has can see our device. > 2) This allows us to remove the pre_init() callback, as it is now unused. > 3) It is a more robust design, as the init() callback is called by > dw_pcie_ep_init_registers(), which will always be called after a core > reset. The pre_init() callback is only called once, at probe time. > > No functional changes. > > Suggested-by: Niklas Cassel <cassel@xxxxxxxxxx> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> > --- Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
