On Tue, Apr 01, 2025 at 10:17:08AM +0100, Marc Zyngier wrote: > From: Hector Martin <marcan@xxxxxxxxx> > > In the success path, we hang onto a reference to the node, so make sure > to grab one. The caller iterator puts our borrowed reference when we > return. > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Acked-by: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx> > Tested-by: Janne Grunau <j@xxxxxxxxxx> > Signed-off-by: Hector Martin <marcan@xxxxxxxxx> > Signed-off-by: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > --- > drivers/pci/controller/pcie-apple.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index 6b04bf0b41dcc..23d9f62bd2ad4 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -593,6 +593,9 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > list_add_tail(&port->entry, &pcie->ports); > init_completion(&pcie->event); > > + /* In the success path, we keep a reference to np around */ > + of_node_get(np); > + > ret = apple_pcie_port_register_irqs(port); > WARN_ON(ret); > > -- > 2.39.2 > -- மணிவண்ணன் சதாசிவம்
