On Fri, Apr 04, 2025 at 08:09:40AM +0200, Krzysztof Kozlowski wrote: > On 03/04/2025 09:43, shao.mingyin@xxxxxxxxxx wrote: > > From: Zhang Enpei <zhang.enpei@xxxxxxxxxx> > > > > Replace the open-code with dev_err_probe() to simplify the code. > > > > Signed-off-by: Zhang Enpei <zhang.enpei@xxxxxxxxxx> > > Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx> > > --- > Considering zte is sending untested patches from poor automation (or AI > generated), this might be correct or might not be because it does not > look like probe path. > > Anyway, don't send patch by patch and line by line. Why you did not > decide to fix all of the places in these drivers? > To bump up the contribution maybe :P But to reiterate what Krzysztof said, please send patches only after fixing all identical issues in the driver. Patches should be split only when the fixes are non-identical. - Mani -- மணிவண்ணன் சதாசிவம்
