On Wed, Apr 02, 2025 at 11:16:28AM +0200, Niklas Cassel wrote: > While I do not have the technical reference manuals, the qcom-ep > maintainer assures me that all compatibles support generating INTx IRQs. > > Thus, set intx_capable to true in epc_features. > > This will currently not have any effect, as PCITEST_IRQ_TYPE_AUTO will > always prefer MSI over INTx when both are available, however, perhaps the > supported irq_types in epc_features will be used for something else, e.g. > failing a ioctl(PCITEST_SET_IRQTYPE) with PCITEST_IRQ_TYPE_INTX, on the > host side, before ever configuring anything on the EP side. Thus, ensure > that epc_features represents reality. > > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> -- With best wishes Dmitry
