On 3/27/2025 12:16 PM, Bjorn Helgaas wrote: > On Wed, Mar 26, 2025 at 08:47:01PM -0500, Terry Bowman wrote: >> ... >> Terry Bowman (16): >> PCI/CXL: Introduce PCIe helper function pcie_is_cxl() > Something like "Add pcie_is_cxl()" is probably enough. > >> PCI/AER: Modify AER driver logging to report CXL or PCIe bus error >> type > No need to repeat "AER" in the subject. Could start with "Report" or > "Distinguish" since "modify AER driver logging" is kind of low-value > information. > >> CXL/AER: Introduce Kfifo for forwarding CXL errors >> cxl/aer: AER service driver forwards CXL error to CXL driver >> PCI/AER: CXL driver dequeues CXL error forwarded from AER service >> driver > Both should say what the patch changes. "AER service driver forwards" > and "CXL driver dequeues" could be descriptions of existing behavior > or something else. Starting with a verb will help make this clearer. > > Maybe don't need to repeat "AER" in "CXL/AER: AER ..." > >> CXL/PCI: Introduce CXL uncorrectable protocol error 'recovery' >> cxl/pci: Move existing CXL RAS initialization to CXL's cxl_port driver > Drop "existing" and at least one "CXL" to increase information density > in subject. > >> cxl/pci: Map CXL Endpoint Port and CXL Switch Port RAS registers >> cxl/pci: Update RAS handler interfaces to also support CXL PCIe Ports >> cxl/pci: Add log message if RAS registers are not mapped >> cxl/pci: Unifi CXL trace logging for CXL Endpoints and CXL Ports > s/Unifi/Unify/ > >> cxl/pci: Assign CXL Port protocol error handlers >> cxl/pci: Assign CXL Endpoint protocol error handlers >> cxl/pci: Remove unnecessary CXL Endpoint handling helper functions >> CXL/PCI: Enable CXL protocol errors during CXL Port probe >> CXL/PCI: Disable CXL protocol errors during CXL Port cleanup > Don't repost just for any of this, but it looks like there are some > kernel test robot warnings that need to be addressed. When you do, > tidy up these subject lines so they are capitalized consistently. Hi Bjorn, I added all the changes. The commit titles read much better. Terry
