On Wed, Mar 26, 2025 at 10:39:50AM -0400, Niklas Cassel wrote: > > > Hello Mani, > > On 22 March 2025 01:31:44 GMT-04:00, Niklas Cassel <cassel@xxxxxxxxxx> wrote: > > > >BTW, can all Qcom platform raise INTx interrupts in EP mode? > > > >Bjorn did not like that I added intx_capable to epc_features without having any platform that sets it to true. I'm quite sure that many platforms can raise INTx interrupts. > >If all Qcom platforms can raise INTx interrupts, > >then I could set intx_capable to true in epc_features in qcom-ep.c, to address Bjorns comment. > > Can all Qcom platforms raise INTx in EP mode? > Yes, all Qcom platforms support INTx. But if we start setting the flag to true, there is no need to set it to false as that would be the default value. So let's just set 'true' for INTx capable platforms and assume others as not supported. I know that you had added justification in the commit message, but I think we'd have to drop the below commit: PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts - Mani -- மணிவண்ணன் சதாசிவம்
