On 2/26/25 8:30 AM, Krzysztof Kozlowski wrote: > On Tue, Feb 25, 2025 at 03:03:58PM +0530, Krishna Chaitanya Chundru wrote: >> From: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> >> >> Add a device tree binding for the Toshiba TC956x PCIe switch, which >> provides an Ethernet MAC integrated to the 3rd downstream port and two >> downstream PCIe ports. >> >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> >> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > Drop, file was named entirely different. I see other changes, altough > comparing with b4 is impossible. > > Why b4 does not work for this patch? > > b4 diff '20250225-qps615_v4_1-v4-1-e08633a7bdf8@xxxxxxxxxxxxxxxx' > Checking for older revisions > Grabbing search results from lore.kernel.org > Nothing matching that query. > > Looks like you use b4 but decide to not use b4 changesets/versions. Why > making it difficult for reviewers and for yourself? > > >> --- >> .../devicetree/bindings/pci/toshiba,tc956x.yaml | 178 +++++++++++++++++++++ >> 1 file changed, 178 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml >> new file mode 100644 >> index 000000000000..ffed23004f0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml > > What is "x" here? Wildcard? Yes, an overly broad one. Let's use the actual name going forward. Konrad
