On 3/25/25 03:20, Niklas Cassel wrote: > Hello Krzysztof, > > On Sun, Mar 23, 2025 at 08:34:49PM +0900, Krzysztof Wilczyński wrote: >> [...] >>> I still need to send a patch that fixes the kdoc. >> >> Feel free to let me know what kernel-doc you want added there. I will, in >> the mean time, go ahead and add something. > > We already have: > > * @msi_capable: indicate if the endpoint function has MSI capability > * @msix_capable: indicate if the endpoint function has MSI-X capability > > How about: > > intx_capable: indicate if the endpoint can raise INTx interrupts It feels like we should just have a @irq_capability field that combines PCI_IRQ_xxx flags to indicate the type(s) of IRQ supported by the controller. That would be way cleaner than one boolean per type :) > > > Kind regards, > Niklas -- Damien Le Moal Western Digital Research
