On Fri, Mar 21, 2025 at 6:39 AM Karolina Stolarek <karolina.stolarek@xxxxxxxxxx> wrote: > This commit description doesn't provide enough information on why and > how we make the names more descriptive. With this change, we want to > make it clear that this function logs information about the Root Port > that received an error message, not just a generic PCIe Port. > > Also, there's a typo in the subject: > s/aer_printrp_info()/aer_print_rp_info()/ > > I'm fine with the code changes but I'd like to see the new commit > description before giving the r-b. Ack. Will add more detail/fix typos (incl. s/institue/institute) in v6. Something like: PCI/AER: Rename aer_print_port_info() to aer_print_rp_info() Update function/param names to be more descriptive. Make it clear that this function logs error information from a root port vs. generic PCIe port. This is a preparatory patch for instituting rate limits on logs. It frees up the dev variable for source device iteration. Thanks, Jon