On Thu, Mar 20, 2025 at 7:58 AM Karolina Stolarek <karolina.stolarek@xxxxxxxxxx> wrote: > > On 20/03/2025 09:20, Jon Pan-Doh wrote: > > +What: /sys/bus/pci/devices/<dev>/aer/ratelimit_in_5secs_cor_log > > I think this attribute name (and the uncor counterpart) is too wordy. A > user can check what this knob controls by looking up this file or AER > docs, so I'd name it to "ratelimit_burst_cor_log" or something along > these lines. Will change in v5. > > +/* > > + * Ratelimit enable toggle uses interval value of > > + * 0: disabled > > + * DEFAULT_RATELIMIT_INTERVAL: enabled > > We set that internally, but to the user we are just operating on 0s and > 1s. I would connect this comment with what we have in the documentation. Will reword in v5 > > + pdev->aer_report->cor_log_ratelimit.interval = interval; > > + pdev->aer_report->uncor_log_ratelimit.interval = interval; > > + return count; > > Nit, suggestion: add a blank line before return (this applies to all > returns in the patch) Ack. Thanks, Jon
