Re: [PATCH v4 3/7] PCI/AER: Move AER stat collection out of __aer_print_error()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/03/2025 09:20, Jon Pan-Doh wrote:
Decouple stat collection from internal AER print functions. Prerequisite
to add ratelimits to logs while leaving stats unaffected. Also simplifies
control flow as stats collection is no longer buried in nested functions.

AERs from ghes or cxl drivers are a minor exception. Stat collection occurs
in pci_print_aer(), an external interface, as that is where aer_err_info
is populated.

Hopefully, I'll get my patch in sooner than later, and the second paragraph (and the related changes) will go away.

As for the first one, I'd restructure it to chain all the sentences together. I'm thinking about something like this:

"
Decouple stat collection from internal AER print functions, so the ratelimit does not impact the error counters. The stats collection is no longer buried in nested functions, simplifying the function flow.
"

All the best,
Karolina





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux