The test cases for read/write/copy currently do: 1) ioctl(PCITEST_SET_IRQTYPE) 2) ioctl(PCITEST_{READ,WRITE,COPY}) The PCITEST_{READ,WRITE,COPY} ioctls now configure the IRQ type to use themselves, ignoring any value configured by the user via ioctl(PCITEST_SET_IRQTYPE). Since PCITEST_{READ,WRITE,COPY} ioctls will ignore the IRQ type set by the user, remove the ioctl(PCITEST_SET_IRQTYPE), as it has no effect on the result of the test case. Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> --- tools/testing/selftests/pci_endpoint/pci_endpoint_test.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c index fdf4bc6aa9d2a..e788ab4eb003e 100644 --- a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c +++ b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c @@ -181,9 +181,6 @@ TEST_F(pci_ep_data_transfer, READ_TEST) if (variant->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; - pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI); - ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type"); - for (i = 0; i < ARRAY_SIZE(test_size); i++) { param.size = test_size[i]; pci_ep_ioctl(PCITEST_READ, ¶m); @@ -200,9 +197,6 @@ TEST_F(pci_ep_data_transfer, WRITE_TEST) if (variant->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; - pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI); - ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type"); - for (i = 0; i < ARRAY_SIZE(test_size); i++) { param.size = test_size[i]; pci_ep_ioctl(PCITEST_WRITE, ¶m); @@ -219,9 +213,6 @@ TEST_F(pci_ep_data_transfer, COPY_TEST) if (variant->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; - pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI); - ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type"); - for (i = 0; i < ARRAY_SIZE(test_size); i++) { param.size = test_size[i]; pci_ep_ioctl(PCITEST_COPY, ¶m); -- 2.48.1