Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

> [...]
> > vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > 
> >    313	
> >    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
> >    315		.init = rockchip_pcie_ep_init,
> >  > 316		.intx_capable = false,
> >    317		.raise_irq = rockchip_pcie_raise_irq,
> >    318		.get_features = rockchip_pcie_get_features,
> >    319	};
> >    320	
> 
> I moved setting the .intx_capable property to false to the pci_epc_features
> struct definition for RK3568, which is what I believe the intention was.
> 
> Have a look at:
> 
>   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=endpoint-test&id=cb349262d9770e6478a7e91bdf438122b8cda44d
> 
> Let me know if this is OK with you.

Niklas, I saw your reply to this failure report.

Based on it, I fixed the patch and dropped any annotations added (since
there was no need to do anything aside from retroing the code to its
orignal form).


That said, I didn't do any edits when applying the patch that I can recall,
so I think something got its knickers in a twist when I was applying the
patches.

However, I did miss that it got applied incorrectly when reviewing the
changes before pushing them.  My bad.

Anyway.  Sorry for the commotion.  I am glad the fix was trivial here.

Thank you!

	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux