Re: [PATCH v4] PCI: vmd: Make vmd_dev::cfg_lock a raw_spinlock_t.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

> > The access to the PCI config space via pci_ops::read and pci_ops::write
> > is a low-level hardware access. The functions can be accessed with
> > disabled interrupts even on PREEMPT_RT. The pci_lock has been made a
> > raw_spinlock_t for this purpose. A spinlock_t becomes a sleeping lock on
> > PREEMPT_RT can not be acquired with disabled interrupts.
> 
> I think this is missing a word or two and should say:
> 
>   A spinlock_t becomes a sleeping lock on PREEMPT_RT, so it cannot be
>   acquired with disabled interrupts.

I changed the commit log directly on the relevant branch.  Thank you!

	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux