On 8/15/25 12:23 PM, Steve Dickson wrote:
> Hello,
>
> On the more recent gcc version (15.1.1) the
> -Wold-style-definition flag is set by default.
>
> This causes
> warning: old-style function definition [-Wold-style-definition]
>
> warnings when functions are defined like
>
> int add(a, b)
> int a;
> int b;
> {}
>
> instead of like this
>
> int add(int a, int b)
> {}
>
> Now I did fix these warnings in the latest rpcbind
> release... But libtirpc is a different story.
>
> I would have to change almost every single function
> in the library to remove these warnings or add I
> could add -Wno-old-style-definition to the CFLAGS.
>
> Now I'm more that willing to do the work... Heck
> I'm halfway through... But does it make sense to
> change the foot print of every function for a
> warning that may not make any sense?
I recommend breaking up the work into several smaller
patches, and posting them here for review before you
commit.
Maybe you could also pass the result through a C linter
or clang-tidy. But don't go too crazy. You get the idea.
Out of curiosity, what is the test plan once your
conversion is code-complete?
--
Chuck Lever
