Re: [PATCH v3 1/2] filemap: Add a helper for filesystems implementing dropbehind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 18, 2025 at 08:59:41AM -0700, Trond Myklebust wrote:
> On Mon, 2025-08-18 at 15:51 +0100, Matthew Wilcox wrote:
> > On Mon, Aug 18, 2025 at 07:39:49AM -0700, Trond Myklebust wrote:
> > > +void folio_end_dropbehind(struct folio *folio)
> > > +{
> > > +	filemap_end_dropbehind_write(folio);
> > > +}
> > > +EXPORT_SYMBOL(folio_end_dropbehind);
> > 
> > Why not just export filemap_end_dropbehind_write()?
> 
> It seemed more appropriate to use the 'folio' prefix when exporting, so
> that it is symmetric with folio_end_writeback().
> 
> I'm perfectly fine with changing that if people disagree.

I don't mind renaming filemap_end_dropbehind_write() to
folio_end_dropbehind() as a solution!




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux