Re: [PATCH] nfs: cleanup tracepoint declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2025-08-21 at 15:04 -0700, Leo Martins wrote:
> Cleanup tracepoint declarations by replacing commas with
> semicolons to better match other tracepoint declarations.
> 
> No functional changes introduced.
> 
> Signed-off-by: Leo Martins <loemra.dev@xxxxxxxxx>
> ---
>  fs/nfs/nfstrace.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h
> index 96b1323318c2..d7ddf3bb5402 100644
> --- a/fs/nfs/nfstrace.h
> +++ b/fs/nfs/nfstrace.h
> @@ -966,7 +966,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event,
>  			__entry->fileid = nfsi->fileid;
>  			__entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
>  			__entry->version = inode_peek_iversion_raw(inode);
> -			__entry->offset = offset,
> +			__entry->offset = offset;
>  			__entry->count = count;
>  		),
>  
> @@ -1016,8 +1016,8 @@ DECLARE_EVENT_CLASS(nfs_folio_event_done,
>  			__entry->fileid = nfsi->fileid;
>  			__entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
>  			__entry->version = inode_peek_iversion_raw(inode);
> -			__entry->offset = offset,
> -			__entry->count = count,
> +			__entry->offset = offset;
> +			__entry->count = count;
>  			__entry->ret = ret;
>  		),
>  

Harmless in this case (luckily), but it's nice to remove a potential
footgun.

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux