My initial attempt to submit this patch was not formatted correctly. The only change in v2 is me trying to use git send-email correctly. Thanks for being patient with me. xs_sock_recv_cmsg was failing to call xs_sock_process_cmsg for any cmsg type other than TLS_RECORD_TYPE_ALERT (TLS_RECORD_TYPE_DATA, and other values not handled.) Based on my reading of the previous commit (cc5d5908: sunrpc: fix client side handling of tls alerts), it looks like only iov_iter_revert should be conditional on TLS_RECORD_TYPE_ALERT (but that other cmsg types should still call xs_sock_process_cmsg). On my machine, I was unable to connect (over mtls) to an NFS share hosted on FreeBSD. With this patch applied, I am able to mount the share again. Based on analysis by Olga Kornievskaia, while this patch does allow Linux to mount FreeBSD exports over (m)tls -- it does not seem to fully correct all underlying issues. I think I’m a bit over my head to analyze the protocol for deeper issues than what I found (which was just thinking through functional differences between the old and new code, and throwing stuff at the wall till it runs.) Obviously it is up to the community and maintainers if stands alone as step in the right direction, or if a full root cause needs to be found and corrected before proceeding with any changes. Justin Worrell (1): call xs_sock_process_cmsg for all cmsg net/sunrpc/xprtsock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.51.0
