On 9/10/25 11:29 AM, Chuck Lever wrote: > From: Chuck Lever <chuck.lever@xxxxxxxxxx> > > NFSv4 clients won't send legitimate GETATTR requests for these new > attributes because they are intended to be used only with CB_GETATTR. > But NFSD has to do something besides crashing if it ever sees such > a request. The correct thing to do is ignore them. > > Reported-by: rtm@xxxxxxxxxxxxx > Closes: https://lore.kernel.org/linux-nfs/7819419cf0cb50d8130dc6b747765d2b8febc88a.camel@xxxxxxxxxx/T/#t Fixes: 51c0d4f7e317 ("nfsd: add support for FATTR4_OPEN_ARGUMENTS") Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > fs/nfsd/nfs4xdr.c | 2 ++ > 1 file changed, 2 insertions(+) > > Compile-tested only. > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index c0a3c6a7c8bb..97e9e9afa80a 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -3560,6 +3560,8 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = { > > [FATTR4_MODE_UMASK] = nfsd4_encode_fattr4__noop, > [FATTR4_XATTR_SUPPORT] = nfsd4_encode_fattr4_xattr_support, > + [FATTR4_TIME_DELEG_ACCESS] = nfsd4_encode_fattr4__noop, > + [FATTR4_TIME_DELEG_MODIFY] = nfsd4_encode_fattr4__noop, > [FATTR4_OPEN_ARGUMENTS] = nfsd4_encode_fattr4_open_arguments, > }; > -- Chuck Lever
