On Thu, Sep 11, 2025 at 2:53 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Sep 10, 2025 at 03:49:21PM -0600, Thomas Bertschinger wrote: > > This pulls the code for opening a file, after its handle has been > > converted to a struct path, into a new helper function. > > > > This function will be used by io_uring once io_uring supports > > open_by_handle_at(2). > > Not commenting on the rest of patchset, but... > > Consider the choice of name NAKed with extreme prejudice. > 0.01:fs/ioctl.c: struct file * filp; > 0.01:fs/ioctl.c: if (fd >= NR_OPEN || !(filp = current->filp[fd])) > which was both inconsistent *and* resembling hungarian notation just > enough to confuse (note that in the original that 'p' does *NOT* stand for > "pointer" - it's "current IO position"). Unfortunately, it was confusing > enough to stick around; at some point it even leaked into function names > (filp_open(); that one is my fault - sorry for that brainfart). > > Let's not propagate that wart any further, please. If you are opening a file, > put "file" in the identifier. > If I may join the bikeshedding. I find that an exported vfs helper called do_file_path_open() does not sound like something that is expected to call path.mnt->mnt_sb->s_export_op->open(). I am not sure how to express that in a good helper name. IDK. Running out of names. Maybe do_handle_path_open()? Thanks, Amir.
