On Wed, 10 Sep 2025, Chuck Lever wrote:
> From: Mike Snitzer <snitzer@xxxxxxxxxx>
>
> Prepares for nfsd_iter_read() to use DIO alignment stored in nfsd_file.
This is particularly unhelpful commit description. It would be
perfectly good as an introduce to a description which actually gives
some details, which could then be compared to the code.
Prepare for nfsd_iter_read() to use the DIO alignment stored in
nfsd_file by passing the nfsd_file to nfsd_iter_read() rather than
just the file which is associaed with the nfsd_file.
This means nfsd4_encode_readv() now also needs the nfsd_file rather
than the file. Instead of changing the file arg to be the nfsd_file,
we discard the file arg as the nfsd_file (and indeed the file) is
already available via the "read" argument.
Now when I read the patch it makes perfect sense.
Reviewed-by: NeilBrown <neil@xxxxxxxxxx>
Thanks,
NeilBrown
>
> Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
> Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
> fs/nfsd/nfs4xdr.c | 8 ++++----
> fs/nfsd/vfs.c | 7 ++++---
> fs/nfsd/vfs.h | 2 +-
> 3 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index c0a3c6a7c8bb..cd3251340b5c 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4465,7 +4465,7 @@ static __be32 nfsd4_encode_splice_read(
>
> static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> struct nfsd4_read *read,
> - struct file *file, unsigned long maxcount)
> + unsigned long maxcount)
> {
> struct xdr_stream *xdr = resp->xdr;
> unsigned int base = xdr->buf->page_len & ~PAGE_MASK;
> @@ -4476,7 +4476,7 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> if (xdr_reserve_space_vec(xdr, maxcount) < 0)
> return nfserr_resource;
>
> - nfserr = nfsd_iter_read(resp->rqstp, read->rd_fhp, file,
> + nfserr = nfsd_iter_read(resp->rqstp, read->rd_fhp, read->rd_nf,
> read->rd_offset, &maxcount, base,
> &read->rd_eof);
> read->rd_length = maxcount;
> @@ -4523,7 +4523,7 @@ nfsd4_encode_read(struct nfsd4_compoundres *resp, __be32 nfserr,
> if (file->f_op->splice_read && splice_ok)
> nfserr = nfsd4_encode_splice_read(resp, read, file, maxcount);
> else
> - nfserr = nfsd4_encode_readv(resp, read, file, maxcount);
> + nfserr = nfsd4_encode_readv(resp, read, maxcount);
> if (nfserr) {
> xdr_truncate_encode(xdr, eof_offset);
> return nfserr;
> @@ -5419,7 +5419,7 @@ nfsd4_encode_read_plus_data(struct nfsd4_compoundres *resp,
> if (file->f_op->splice_read && splice_ok)
> nfserr = nfsd4_encode_splice_read(resp, read, file, maxcount);
> else
> - nfserr = nfsd4_encode_readv(resp, read, file, maxcount);
> + nfserr = nfsd4_encode_readv(resp, read, maxcount);
> if (nfserr)
> return nfserr;
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 714777c221ed..441267d877f9 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1078,7 +1078,7 @@ __be32 nfsd_splice_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> * nfsd_iter_read - Perform a VFS read using an iterator
> * @rqstp: RPC transaction context
> * @fhp: file handle of file to be read
> - * @file: opened struct file of file to be read
> + * @nf: opened struct nfsd_file of file to be read
> * @offset: starting byte offset
> * @count: IN: requested number of bytes; OUT: number of bytes read
> * @base: offset in first page of read buffer
> @@ -1091,9 +1091,10 @@ __be32 nfsd_splice_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> * returned.
> */
> __be32 nfsd_iter_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> - struct file *file, loff_t offset, unsigned long *count,
> + struct nfsd_file *nf, loff_t offset, unsigned long *count,
> unsigned int base, u32 *eof)
> {
> + struct file *file = nf->nf_file;
> unsigned long v, total;
> struct iov_iter iter;
> struct kiocb kiocb;
> @@ -1334,7 +1335,7 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> if (file->f_op->splice_read && nfsd_read_splice_ok(rqstp))
> err = nfsd_splice_read(rqstp, fhp, file, offset, count, eof);
> else
> - err = nfsd_iter_read(rqstp, fhp, file, offset, count, 0, eof);
> + err = nfsd_iter_read(rqstp, fhp, nf, offset, count, 0, eof);
>
> nfsd_file_put(nf);
> trace_nfsd_read_done(rqstp, fhp, offset, *count);
> diff --git a/fs/nfsd/vfs.h b/fs/nfsd/vfs.h
> index 0c0292611c6d..fa46f8b5f132 100644
> --- a/fs/nfsd/vfs.h
> +++ b/fs/nfsd/vfs.h
> @@ -121,7 +121,7 @@ __be32 nfsd_splice_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> unsigned long *count,
> u32 *eof);
> __be32 nfsd_iter_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> - struct file *file, loff_t offset,
> + struct nfsd_file *nf, loff_t offset,
> unsigned long *count, unsigned int base,
> u32 *eof);
> bool nfsd_read_splice_ok(struct svc_rqst *rqstp);
> --
> 2.50.0
>
>
>
