Re: [PATCH 4/5] nfsdfs_create_files(): switch to simple_start_creating()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 4/5] nfsdfs_create_files(): switch to simple_start_creating()
From: "NeilBrown" <neilb@xxxxxxxxxxx>
Date: Fri, 12 Sep 2025 09:20:25 +1000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, jlayton@xxxxxxxxxx
Feedback-id: iab3e480c:Fastmail
In-reply-to: <20250911224628.1591565-4-viro@zeniv.linux.org.uk>
References: <>, <20250911224628.1591565-4-viro@zeniv.linux.org.uk>
Reply-to: neil@xxxxxxxxxx

>  		inode->i_private = ncl;
> -		d_add(dentry, inode);
> +		d_instantiate(dentry, inode);
>  		fsnotify_create(dir, dentry);
>  		if (fdentries)
>  			fdentries[i] = dentry;

I wonder if we should get rid of that if (fdentries) test one day.
fdentries is never NULL.

NeilBrown

References:
- [PATCH 4/5] nfsdfs_create_files(): switch to simple_start_creating()
  - From: Al Viro

Prev by Date: [PATCH 5/5] nfsd_get_inode(): lift setting ->i_{,f}op to callers.
Next by Date: Re: [PATCHES] nfsctl fix and cleanups
Previous by thread: [PATCH 4/5] nfsdfs_create_files(): switch to simple_start_creating()
Next by thread: [PATCH 5/5] nfsd_get_inode(): lift setting ->i_{,f}op to callers.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]

Powered by Linux