On 13 Aug 2025, at 5:00, Anthony Iliopoulos wrote: > When client initialization goes through server trunking discovery, it > schedules the state manager and then sleeps waiting for nfs_client > initialization completion. > > The state manager can fail during state recovery, and specifically in > lease establishment as nfs41_init_clientid() will bail out in case of > errors returned from nfs4_proc_create_session(), without ever marking > the client ready. The session creation can fail for a variety of reasons > e.g. during backchannel parameter negotiation, with status -EINVAL. > > The error status will propagate all the way to the nfs4_state_manager > but the client status will not be marked, and thus the mount process > will remain blocked waiting. > > Fix it by adding -EINVAL error handling to nfs4_state_manager(). Looks correct, but consider reducing the scope of this change by handling the error within nfs41_init_clientid() instead of modifying all the possible paths that might return -EINVAL from the state manager. IMO a comment about -EINVAL probably resulting from improper negotiation would be nice as well. Ben
